Skip to content

Fixed failures in download tests #9727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2020
Merged

Fixed failures in download tests #9727

merged 2 commits into from
Feb 6, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 6, 2020

This PR should fix 2 failing test:

  • JsonDownloaderTest.testJsonDownload
  • GzippedJsonDownloaderTest.testJsonDownload

Supersedes #9699

@cmaglie cmaglie self-assigned this Feb 6, 2020
@cmaglie
Copy link
Member Author

cmaglie commented Feb 6, 2020

@tlk it seems that the gh-action is not triggered on pull-requests, I guess we should change the config file and change:

on: [push]

to

on:
  push:
  pull_request:

@cmaglie cmaglie force-pushed the fix-downloadtest-failures branch from 213ecb3 to b59c91e Compare February 6, 2020 15:05
@cmaglie cmaglie merged commit b59c91e into arduino:master Feb 6, 2020
@cmaglie cmaglie deleted the fix-downloadtest-failures branch February 6, 2020 15:10
@cmaglie cmaglie mentioned this pull request Feb 6, 2020
Closed
7 tasks
@cmaglie cmaglie added this to the Release 1.8.12 milestone Feb 6, 2020
@arduino arduino deleted a comment from ArduinoBot Feb 6, 2020
@arduino arduino deleted a comment from ArduinoBot Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
Release 1.8.12
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @flsewf